Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple download ranges in download in menu #72

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

sudoAlphaX
Copy link
Contributor

Improvement to 98e41e1 which allows selection of multiple download
ranges.

Example: :3 5:7 10 13 15:16 19:
will download 1,2,3,5,7,10,13,15,16,19 till the end

Variables can be named better.

Please check before merging.

@sudoAlphaX
Copy link
Contributor Author

lmao didnt rebase give me a moment

@sudoAlphaX sudoAlphaX force-pushed the multiple-download-ranges branch from 1721342 to 8199656 Compare February 23, 2025 17:30
Improvement to 98e41e1 which allows selection of multiple download
ranges.

Example: :3 5:7 10 13 15:16 19:
will download 1,2,3,5,7,10,13,15,16,19 till the end

Variables can be named better.
@sudoAlphaX sudoAlphaX force-pushed the multiple-download-ranges branch from 8199656 to 6756540 Compare February 23, 2025 17:37
@Benexl
Copy link
Owner

Benexl commented Feb 23, 2025

honestly don't feel like reading it so am going to try it and check for errors

@Benexl
Copy link
Owner

Benexl commented Feb 23, 2025

Thats one hell of edge case though lol, okey am getting errors and am tired will look at it better tomorrow

@sudoAlphaX
Copy link
Contributor Author

:(

@Benexl
Copy link
Owner

Benexl commented Mar 2, 2025

Sorry for the late merge, but it works just okey but ensure you include instructions for it.
Plus add error handling when the user inputs invalid ranges

@Benexl Benexl merged commit 6887c6f into Benexl:master Mar 2, 2025
2 checks passed
@sudoAlphaX
Copy link
Contributor Author

Alright, open a pr with additional help.
Thanks for the merge

@sudoAlphaX sudoAlphaX deleted the multiple-download-ranges branch March 2, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants