Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to kill wg job #1192

Closed
r00t0v3rr1d3 opened this issue Apr 10, 2023 · 1 comment
Closed

Unable to kill wg job #1192

r00t0v3rr1d3 opened this issue Apr 10, 2023 · 1 comment
Labels
investigating

Comments

@r00t0v3rr1d3
Copy link
Contributor

Describe the bug
Unable to kill wg job. It says killed, but shows still running. Then if you try again, it hangs forever.

To Reproduce
Steps to reproduce the behavior:

  1. See picture

Screenshots
sliver_wireguard_failed_jobkill

Desktop (please complete the following information):

  • OS: Kali Linux
  • Version v.1.5.36 release binary

Additional context
Add any other context about the problem here.
RafBishopFox added a commit that referenced this issue Apr 11, 2023
@RafBishopFox
Fixing #1192. Waiting to close the job channel until all teardown tas…
f09efe9 
…ks are done
@RafBishopFox
Copy link
Collaborator

Good catch. Thanks for reporting this. I took a look, and I think we were calling the job done before we finishing tearing down the listener. I believe this is now fixed in commit f09efe9

image

The listening socket is also closed when I run netstat / ss.

@RafBishopFox RafBishopFox mentioned this issue Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
investigating
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@moloch-- @r00t0v3rr1d3 @rkervella @RafBishopFox