Initialize Orakl Network API through orakl-cli
#336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkersner
deleted the
i-335/feat/initialized-orakl-api-through-orakl-cli
branch
5 tasks
bayram98
reviewed
Mar 6, 2023
| { | ||
| "function": "PARSE", | ||
| "args": ["result", "list"] | ||
| "name": "Bybit-ticker-BTC-USDT", |
There was a problem hiding this comment.
General structure in naming of feeds looks like CEXName-X-Y
Is there any reason why we put ticker in only Bybit ?
There was a problem hiding this comment.
This is good finding! It is mistake.
At some point I thought there were more queries than one for Bybit, therefore I wanted to distinguish between them. Then, I realized I was wrong but did not fix this one. If you have time, can you please make a bugfix for this?
There was a problem hiding this comment.
Sure. I will create an issue and fix it.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR connects
orakl-cliwith Orakl Network API to enable creation of:Chain(list, insert, remove)Adapter(list, insert, remove)Aggregator(list, insert, remove)Environment variable
ORAKL_NETWORK_API_URL- URL to connect to Orakl Network APIIt will be necessary to implement validation of inserter adapter and aggregator #339
Type of change
Checklist before requesting a review
Deployment