Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listener setup through new --service param #400

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Listener setup through new --service param #400

merged 1 commit into from
Mar 17, 2023

Conversation

martinkersner
Copy link
Member

Description

This PR fixed issue in listener. Previously, we accidentally fix the listener for VRF service only.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code.

Deployment

  • Should publish Docker image

@martinkersner martinkersner self-assigned this Mar 17, 2023
@martinkersner martinkersner marked this pull request as ready for review March 17, 2023 02:50
@martinkersner martinkersner added the bug Something isn't working label Mar 17, 2023
@martinkersner martinkersner merged commit 67446eb into master Mar 17, 2023
@martinkersner martinkersner deleted the hotfix/request-response-listener branch March 17, 2023 02:52
bayram98
bayram98 reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@bayram98 bayram98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bayram98 bayram98 bayram98 left review comments

@jo-bisonai jo-bisonai Awaiting requested review from jo-bisonai

@KelvinThai KelvinThai Awaiting requested review from KelvinThai

Assignees

@martinkersner martinkersner

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinkersner @bayram98