Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme fixed & redis client connect with host:port in initial stage #445

Merged
merged 8 commits into from
Mar 24, 2023

Conversation

jo-bisonai
Copy link
Member

@jo-bisonai jo-bisonai commented Mar 24, 2023

Description

  • readme fixed
  • redis client connect with host:port in the initial stage other wise container start failed because redis connection error

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@jo-bisonai jo-bisonai added the bug Something isn't working label Mar 24, 2023
@jo-bisonai jo-bisonai self-assigned this Mar 24, 2023
@jo-bisonai jo-bisonai linked an issue Mar 24, 2023 that may be closed by this pull request
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinkersner martinkersner merged commit 78f3d26 into master Mar 24, 2023
@martinkersner martinkersner deleted the i-444/readme-fixed branch March 24, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme fixed
2 participants