Remove failed data feeds in Orakl Network Fetcher before inserting to the Orakl Network API #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkersner
changed the title
martinkersner
deleted the
i-452/feat/check-on-inserting-data-through-fetcher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, when data collection failed for any resource, value of that data feed was set
undefined. After submitting data withundefinedvalue(s) to the Orakl Network API, theundefinedvalue was rejected to be inserted and caused an error for all values that were supposed to be submitted at that time as a part of multi record insert transaction.Additionally, this PR defines several types for safes object property access.
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment