Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listener 2.0 #493

Merged
merged 27 commits into from
Apr 12, 2023
Merged

Listener 2.0 #493

merged 27 commits into from
Apr 12, 2023

Conversation

martinkersner
Copy link
Member

@martinkersner martinkersner commented Apr 7, 2023 •
edited
Loading

Description

This PR introduces a new Orakl Network listener service. The new listener version ensures that no events are missed. It also offers to fetch old events retrospectively.

There are no changes related to settings of listener.

Architecture

flowchart LR
   launch-->latest
   latest-- repeatable job -->latest
   launch-->history
   latest-- success -->processEvent
   latest-- failure -->history
   history-->processEvent
   processEvent-- end of listener -->worker
Loading

Others

  • Updated localhost migration scripts
  • Removed localhost migration lock files
  • Added MIT license

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code.

Deployment

  • Should publish npm package
  • Should publish Docker image

@martinkersner martinkersner self-assigned this Apr 7, 2023
This was linked to issues Apr 7, 2023
Use repeatable queue for listener instead of setInterval #446
Closed
Listener can miss some events (or blocks?) #465
Closed
Split listener loop to two: The latest blocks and blocks that haven't been processed after a service restart #488
Closed
@martinkersner
feat: Improve error catching in [latest] listener job
8042f12
@martinkersner
feat: Improve listener logging system
db93e42
@martinkersner
fix: Change comment location
ea175e8
@martinkersner
feat: Add MIT license
76218c3
@martinkersner
feat: Add listener explanation comments
597336d
@martinkersner
fix: lint
82e9e29
@martinkersner
chore: listenerService description
c559b57
@martinkersner
feat: Use listener job settings for RR
3a68a66
@martinkersner
chore: Listener state description
97beec0
@martinkersner
chore: Update descriptions of listener's ephemeral state
b37df58
@martinkersner
feat: Resolve type issue
bcdfa50
@martinkersner
feat: Change location of reporter log message
b693fd3
@martinkersner
feat: Set observed block number for all listener initialization types
b52e67e
@martinkersner
feat: Send processed data from listener to worker
23a5775
@martinkersner
feat: Update comment
f552a20
@martinkersner
feat: Integrate new listener with VRF
09c5d19
@martinkersner
feat: Integrate new listener to data feed service
b943a29
@martinkersner
fix: eslint
f1b1ab6
@martinkersner
fix: Remove outdated intervalId property
29228fc
@martinkersner
fix: Don't allow latestBlock to be smaller than observedBlock
1ef2cc7
@martinkersner
feat: Return undefined when listener does not pass data further
c535f7c
@martinkersner
fix: Change history queue name in data feed listener
4d1ee79
@martinkersner
feat: Update default observedBlock value for clear init
d2486aa
@martinkersner
chore: Update comment
6f70f04
@martinkersner martinkersner marked this pull request as ready for review April 10, 2023 12:35
@martinkersner
Copy link
Member Author

@kodyfanz This PR solves the issue #474 you raised. If you have time, it would be great if you can take a look at the code 🔥

bayram98
bayram98 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@bayram98 bayram98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinkersner martinkersner merged commit 062fdd6 into master Apr 12, 2023
@martinkersner martinkersner deleted the i-465/fix/listener-miss-events branch April 12, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bayram98 bayram98 bayram98 approved these changes

@KelvinThai KelvinThai Awaiting requested review from KelvinThai

Assignees

@martinkersner martinkersner

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@martinkersner @bayram98