Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegator git actions building image #520

Merged
merged 7 commits into from
Apr 13, 2023
Merged

Delegator git actions building image #520

merged 7 commits into from
Apr 13, 2023

Conversation

jo-bisonai
Copy link
Member

@jo-bisonai jo-bisonai commented Apr 12, 2023 •
edited
Loading

Description

This PR is building image and upload to ECR for delegator

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@jo-bisonai jo-bisonai self-assigned this Apr 12, 2023
@jo-bisonai jo-bisonai linked an issue Apr 12, 2023 that may be closed by this pull request
delegator git actions building image #519
Closed
bayram98
bayram98 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@bayram98 bayram98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

martinkersner
martinkersner approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jo-bisonai jo-bisonai merged commit a9b1aee into master Apr 13, 2023
@jo-bisonai jo-bisonai deleted the i-519/delegator-git-actions-building-image branch April 13, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkersner martinkersner martinkersner approved these changes

@bayram98 bayram98 bayram98 approved these changes

Assignees

@jo-bisonai jo-bisonai

Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delegator git actions building image
3 participants
@jo-bisonai @martinkersner @bayram98