Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better way to test on-chain code #531

Merged
merged 16 commits into from
Apr 19, 2023
Merged

Better way to test on-chain code #531

merged 16 commits into from
Apr 19, 2023

Conversation

martinkersner
Copy link
Member

@martinkersner martinkersner commented Apr 18, 2023 •
edited
Loading

Description

This PR adds more tests for VRF and RR to increase project test coverage. It also experiments with a ways how to structure an on-chain test code. @bisonai/orakl-contracts have been modified to use ESM javascript (hardhat does not support ESM typescript) to be able to import @bisonai/orakl-vrf.

Additionally, this PR modifies @bisonai/orakl-vrf package to include the processVrfRequest function and adds custom exceptions.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package (@bisonai/orakl-vrf)

@martinkersner martinkersner self-assigned this Apr 18, 2023
@martinkersner martinkersner linked an issue Apr 18, 2023 that may be closed by this pull request
Find out a better way to test code #507
Closed
@martinkersner martinkersner changed the title Better way to test code Better way to test on-chain code Apr 19, 2023
@martinkersner martinkersner marked this pull request as ready for review April 19, 2023 02:12
bayram98
bayram98 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@bayram98 bayram98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinkersner martinkersner merged commit 57d7805 into master Apr 19, 2023
@martinkersner martinkersner deleted the i-507/feat/better-way-to-test-code branch April 19, 2023 02:46
@martinkersner martinkersner mentioned this pull request Apr 19, 2023
Merged
2 tasks
martinkersner added a commit that referenced this pull request Apr 19, 2023
@martinkersner
Add missing changes from #531 (#535)
836b9d4 
* fix: Add missing changes

* feat: Use @bisonai/orakl-vrf@0.2.0 for @bisonai/orakl-contracts

* fix: Better check in `Prepayment.isValid`

* fix: Remove `build` command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bayram98 bayram98 bayram98 approved these changes

@KelvinThai KelvinThai Awaiting requested review from KelvinThai

Assignees

@martinkersner martinkersner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find out a better way to test code
2 participants
@martinkersner @bayram98