Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove serviceId from Reporter table #534

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

bayram98
Copy link
Contributor

@bayram98 bayram98 commented Apr 19, 2023

Description

This PR is to change uniqueness of Reporter, which is to force make unique reporter in each chain for all types of services. Previously, it was allowed to use same reporter for different services.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code.

Sorry, something went wrong.

@bayram98 bayram98 added bug Something isn't working cli api labels Apr 19, 2023
@bayram98 bayram98 self-assigned this Apr 19, 2023
@bayram98 bayram98 linked an issue Apr 19, 2023 that may be closed by this pull request
@bayram98 bayram98 requested a review from martinkersner April 19, 2023 03:23
@bayram98 bayram98 marked this pull request as ready for review April 19, 2023 03:29
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinkersner martinkersner merged commit d68bf55 into master Apr 20, 2023
@martinkersner martinkersner deleted the i-533/fix/prisma-reporter-uniqueness branch April 20, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug Something isn't working cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix cli prisma Reporter table uniqueness
2 participants