Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library cleanup #537

Merged
merged 5 commits into from
Apr 21, 2023
Merged

Library cleanup #537

merged 5 commits into from
Apr 21, 2023

Conversation

martinkersner
Copy link
Member

@martinkersner martinkersner commented Apr 20, 2023

Description

This PR updates on-chain libraries.

  • Use the same Buffer library as Chainlink
  • Remove Math library (only max function used, now part of Buffer library)
  • Remove SafeSignedMath library (arithmetic operation are safe by default with Solidity >= 0.8.0)
  • Add Median tests
  • Add unchecked for Median.partition function which exploits under/overflow behavior

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@martinkersner martinkersner self-assigned this Apr 20, 2023
@martinkersner martinkersner merged commit 1156027 into master Apr 21, 2023
@martinkersner martinkersner deleted the i-536/feat/median-for-uint256 branch April 21, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant