Remove compilation warning from Median
library
#588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solidity compiler is not able to understand that infinity loop never finishes, therefore it assumes that there is a chance that return variable might not be initialized and warns about that during compilation step. It recommends to name the variable which we cannot do in our case because we are reusing the same input parameter as return value as well.
According to ethereum/solidity#13746, we can simply add a
revert()
statement that notifies compiler with a zero cost that loop will never break, therefore we do not need to add an additional return statement after an infinite loop.Type of change
Please delete options that are not relevant.
Checklist before requesting a review