Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat connect info data #643

Merged
merged 9 commits into from
May 26, 2023
Merged

Feat connect info data #643

merged 9 commits into from
May 26, 2023

Conversation

joeybisonai
Copy link
Member

@joeybisonai joeybisonai commented May 25, 2023 •
edited
Loading

Description

fix layout
data fetch logic
connect queueInfo data
logs display method

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code.

@joeybisonai joeybisonai self-assigned this May 25, 2023
@joeybisonai joeybisonai linked an issue May 25, 2023 that may be closed by this pull request
Connect info data #640
Closed
@joeybisonai joeybisonai requested a review from jo-bisonai May 25, 2023 09:55
martinkersner
martinkersner approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

martinkersner
martinkersner approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joeybisonai joeybisonai merged commit 9b64383 into master May 26, 2023
@joeybisonai joeybisonai deleted the i-640/feat/connect-info-data branch May 26, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkersner martinkersner martinkersner approved these changes

@jo-bisonai jo-bisonai Awaiting requested review from jo-bisonai

Assignees

@joeybisonai joeybisonai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect info data
2 participants
@joeybisonai @martinkersner