Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect audit finding 2 #645

Merged
merged 2 commits into from
May 26, 2023
Merged

Reflect audit finding 2 #645

merged 2 commits into from
May 26, 2023

Conversation

martinkersner
Copy link
Member

@martinkersner martinkersner commented May 26, 2023

Description

jobId should be unique to every fulfillment function based on the response data type. This PR add a security check for jobId passed in RequestCommitment to every Request-Response fulfillment function.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@martinkersner martinkersner self-assigned this May 26, 2023
@martinkersner martinkersner requested a review from bayram98 as a code owner May 26, 2023 07:08
@martinkersner martinkersner requested a review from KelvinThai May 26, 2023 07:08
Copy link
Contributor

@bayram98 bayram98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KelvinThai KelvinThai merged commit 9216eb9 into master May 26, 2023
@martinkersner martinkersner deleted the feat/reflect-audit-finding-2 branch May 27, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants