Allow to withdraw $KLAY from temporary account

[martinkersner]

Description

Request created by temporary account can be canceled. In both VRF

orakl/contracts/src/v0.1/VRFCoordinator.sol

Lines 364 to 372 in 8d4657c

	sRequestIdToCommitment[requestId] = computeCommitment(
	requestId,
	block.number,
	accId,
	callbackGasLimit,
	numWords,
	msg.sender
	);
	sRequestOwner[requestId] = msg.sender;

and RR

orakl/contracts/src/v0.1/RequestResponseCoordinator.sol

Lines 518 to 529 in 8d4657c

	sRequestIdToCommitment[requestId] = computeCommitment(
	requestId,
	block.number,
	accId,
	numSubmission,
	callbackGasLimit,
	msg.sender,
	isDirectPayment,
	req.id
	);
	sRequestOwner[requestId] = msg.sender;

, request commitment and owner of request are stored in contract local storage. The exactly same code is used for temporary account and permanent account. Any request can therefore be canceled using cancelRequestFunction

orakl/contracts/src/v0.1/CoordinatorBase.sol

Lines 124 to 137 in 8d4657c

	function cancelRequest(uint256 requestId) external {
	if (!isValidRequestId(requestId)) {
	revert NoCorrespondingRequest();
	}
	if (sRequestOwner[requestId] != msg.sender) {
	revert NotRequestOwner();
	}
	delete sRequestIdToCommitment[requestId];
	delete sRequestOwner[requestId];
	emit RequestCanceled(requestId);
	}

. Once the request is canceled, it cannot be fulfilled by any oracle because we have a validation of response in both RR

orakl/contracts/src/v0.1/RequestResponseCoordinator.sol

Lines 554 to 557 in 8d4657c

	bytes32 commitment = sRequestIdToCommitment[requestId];
	if (commitment == 0) {
	revert NoCorrespondingRequest();
	}

and VRF

orakl/contracts/src/v0.1/VRFCoordinator.sol

Lines 422 to 425 in 8d4657c

	bytes32 commitment = sRequestIdToCommitment[requestId];
	if (commitment == 0) {
	revert NoCorrespondingRequest();
	}

.

When the request is canceled, the request itself cannot be used to charge for service fee. In case of permanent account, we have a witdthraw function

orakl/contracts/src/v0.1/Prepayment.sol

Lines 366 to 377 in 8d4657c

	function withdraw(uint64 accId, uint256 amount) external onlyAccountOwner(accId) {
	if (pendingRequestExists(accId)) {
	revert PendingRequestExists();
	}
	(bool sent, uint256 balance) = sAccIdToAccount[accId].withdraw(amount);
	if (!sent) {
	revert FailedToWithdraw();
	}
	emit AccountBalanceDecreased(accId, balance + amount, balance);
	}

, but for the temporary account $KLAY deposited during the request is basically stuck in the Prepayment contract, nobody can withdraw them, not even owner of the contract.

This PR allows to withdraw $KLAY from temporary account by owner of the account which requested for a service but the request was eventually canceled.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.

[bayram98]

LGTM!