Expand pressure sensor and setpoint #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtfierro Please see #603 as a possible solution for the failed build https://github.com/BrickSchema/Brick/actions/runs/7293521910/job/19876738252?pr=607. |
…com/mapped/Brick into expand-pressure-sensor-and-setpoint
|
I merged your PR. Thanks for making the change! I usually don't run into this problem because I just run tests locally
…--
Dr. Gabe Fierro | https://home.gtf.fyi<https://home.gtf.fyi/>
Assistant Professor of Computer Science | Colorado School of Mines
Joint Appointment | National Renewable Energy Laboratory
________________________________
From: Connor Cantrell ***@***.***>
Sent: Friday, January 12, 2024 9:41:24 AM
To: BrickSchema/Brick ***@***.***>
Cc: Gabe Fierro ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [BrickSchema/Brick] Expand pressure sensor and setpoint (PR #607)
CAUTION: This email originated from outside of the Colorado School of Mines organization. Do not click on links or open attachments unless you recognize the sender and know the content is safe.
Hi @gtfierro<https://github.com/gtfierro>,
Is there a way to see the obsolete terms file from the output of the build process? It would be helpful to see the which terms are causing the assertion. I also created a PR for outputting the terms in the error message: #609<#609>
—
Reply to this email directly, view it on GitHub<#607 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAANRCXRVLQ2EHP53LMU3OLYOFRTJAVCNFSM6AAAAABA67TZAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGYZDGOBSGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing to expand upon pressure sensor and setpoint classes, including static air pressure, differential pressure, and water pressure. Based on #551 issue.