Lut generation and schema search #49
Open
+4,560
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/srikanth-iyer/CANA into LUT-generation-and-schema-search
|
@fcphysics Can you have a look at this pull request please? I've added Ke for anni_gen rules as well in this |
fcphysics
reviewed
Oct 21, 2024
| """ | ||
| generated_node = None | ||
| closest_node = None | ||
| closest_ke = None |
There was a problem hiding this comment.
Are those initial settings of the parameters to "None" necessary? Because it might make debugging more difficult later.
fcphysics
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Great job @srikanth-iyer, those are necessary improvements.
Would you mind adding a description/disclaimer on the README file about what is in the automata folder?
This is because "automata" is more general than "boolean_node" in the sense that it could take more states. However, this is not what the code considers. We are still in the "boolean realm", but we are interested in specific features focusing on annihilation and generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added schema search rules, sample automata rules, tests, input symmetry for anni_gen in BooleanNode among others.
@fcphysics if you have time, i'll be happy to go through the changes with you. Please let me know if you can review these changes. I need them on the casci repo because some of the functions will be used in the noisy cellular automata GA.
@jcrozum also adding you here. I'm assuming that you're busy settling in, but in case you have time to check the code, please let me know. I'd love your input.
And sorry for the big pull request.