Add LCDDRVCE library #593
Draft
Add LCDDRVCE library #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e enums for flag and field constants
calc84maniac
requested review from
adriweb,
runer112,
mateoconlechuga and
ZERICO2005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can do wacky LCD commands and stuff
I'd like some feedback on the API and docs, if possible. I consider the library implementation itself and its exported API to be more-or-less set in stone at this point, but the convenience macros can be changed as much as needed before merging.
I'm considering removing the bitfield-based raw parameter structs now that I've added parameter constants for most of the relevant commands. Though, that does bring to mind that we're missing a good way to define gamma parameters in C. Of course, that can be added later if needed.