Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was comparing
__imulu
to_MultiplyHLBC
. Since there is no branching in either routine, I could remove instructions that were common to both routines. I then found that__imulu
is faster and smaller. With the only difference being that it preservesAF
, while_MultiplyHLBC
destroysAF
.Based on this,
_MultiplyHLBC
has been replaced with the code for__imulu
. It seems likeA
doesn't need to be preserved based on the routines that use_MultiplyHLBC
, so it seems safe to comment outpush af \ pop af
.In total this should remove 13 bytes + 13F + 3W from
_MultiplyHLBC
.