Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query display in summary #318

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Conversation

c-martinez
Copy link
Collaborator

For queries displayed in the detail of swagger-ui, the first line of the query is being removed (commented out).

For example this query:

#+ summary: Returns the bands
#+ endpoint: http://dbpedia.org/sparql

PREFIX dbo: <http://dbpedia.org/ontology/>

SELECT ?band WHERE {
  ?band a dbo:Band .
  ?band dbo:genre ?__genre_iri .
} 
LIMIT 30

Is displayed like this (summary is missing):
image

This PR fixes this issue.

@c-martinez c-martinez changed the base branch from master to dev February 8, 2021 19:29
@albertmeronyo
Copy link
Member

Thanks for this @c-martinez
I'm merging and I absolutely agree that better handling of query errors should be handled more elegantly. I've opened issue #320 about bad query metadata

@albertmeronyo albertmeronyo merged commit bc8754d into CLARIAH:dev Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants