Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneTimetokenAuthenticator as part of the magic link feature #97

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

ajibarra
Copy link
Member

No description provided.

@ajibarra ajibarra force-pushed the feature/magic-link branch 15 times, most recently from 3d1d4ba to 272ba5e Compare February 14, 2025 10:11
Copy link
Member

@steinkel steinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also correct the phpstan related issues


$usersTable = TableRegistry::getTableLocator()->get(Configure::read('Users.table'));

$user = $usersTable->loginWithToken($token);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to define an interface, then check it's implemented by the table, or check the method exists

@ajibarra ajibarra force-pushed the feature/magic-link branch 2 times, most recently from 7f60077 to 9cbc4ce Compare March 6, 2025 11:34
@ajibarra ajibarra force-pushed the feature/magic-link branch from 9cbc4ce to 03f427c Compare March 6, 2025 11:41
@ajibarra ajibarra marked this pull request as ready for review March 6, 2025 11:45
@steinkel steinkel merged commit 51bf070 into 10.next-cake5 Mar 6, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants