Skip to content
This repository was archived by the owner on Nov 22, 2022. It is now read-only.

Fixes Issue#25: Change boost state based on running application(s)? #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LavaTiger99
Copy link
Contributor

Enhancement for Issue #25
Created Auto Game Switching mode, which automatically changes the plan based on whether user defined programs are running or not, then changes it back to previous once that program(s) closes.

Updated config variables for user, and readme with instructions.

@CappyT
Copy link
Owner

CappyT commented Jul 8, 2020

I cannot merge this.
It does not address the issue itself, that requires certain applications "a list of applications" to be paired with a "list of profiles". I think a better system must be implemented.

Other than that, the code is also extremely heavy and breaks the app. The "time.sleep" interrupts the main thread, which renders the icon app unusable. Also, the usage of infinite while loops is strongly discouraged in general programming.

@LavaTiger99
Copy link
Contributor Author

LavaTiger99 commented Jul 9, 2020

  1. The user was requesting toggling boost depending on what application is running:

ability to toggle whether boost is enabled based on what applications are running. (e.g. leave it on by default, but disable while games that stress the CPU are running or leave off by default but enable for certain applications.)

I took that one step further and allow choosing a whole plan to run based on what applications are running.
Perhaps the original requester @darkforcesjedi can comment on this and clarify if I missed the point.

  1. Yes, I am aware that constantly checking processes does increase workload, and I put a warning about this in the instructions, and this is why it is disabled by default in config. Also mentioned in the instructions is my results on running a benchmark with and without this mode running, and noticed no significant difference. A battery drain test might also be considered in future.

  2. This creates a separate thread process that the while loop runs in, and ONLY if gaming mode is enabled (disabled by default as above). It does not break the app, please try it before rejecting the change. I have been using this version of the app as well as the dc/ac auto switching app (which also uses a separate thread process for monitoring and switching) on my computer for the past 24 hours with no issues, and it is working as expected. Sometimes infinite loops are required, especially if you want to indefinitely check/perform something.

Please let me know if you have any more concerns.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants