Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seeding per process #141

Merged
merged 1 commit into from
Dec 17, 2022
Merged

Fix seeding per process #141

merged 1 commit into from
Dec 17, 2022

Conversation

maxreciprocate
Copy link
Collaborator

@maxreciprocate maxreciprocate commented Dec 17, 2022 •
edited
Loading

This pr will grant each process to have a seed of its own
Tested with accelerate==0.15.0
PPO difference

jon-tow
jon-tow approved these changes Dec 17, 2022
View reviewed changes
Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jon-tow jon-tow merged commit 53f577a into main Dec 17, 2022
@jon-tow jon-tow mentioned this pull request Dec 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jon-tow jon-tow jon-tow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxreciprocate @jon-tow