Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pad_token for all tokenizers in tests #414

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

cat-state
Copy link
Collaborator

Tests were breaking due to one of the self._create_inputs in the model tests not doing this

@cat-state cat-state requested a review from jon-tow April 4, 2023 12:27
@cat-state cat-state changed the title tokenizer.pad_token = tokenizer.eos_token in tests Set pad_token for all tokenizers in tests Apr 4, 2023
Copy link
Collaborator

@jon-tow jon-tow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that tokenizer.pad_token = tokenizer.eos_token didn't silence the errors.
Looks good to me though 😁 Thanks, Aman!

@jon-tow jon-tow merged commit fdf4c16 into main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants