-
Notifications
You must be signed in to change notification settings - Fork 49
ARM test && CASTXML 0.6.11 #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@iMichka @thewtex well! it has the bug that I found in OMPL ompl/ompl#1234 #197 It occurs with > 20.04 linux versions not was only in aarch64 |
I've seen that castxml if(LLVM_VERSION_MAJOR GREATER 15)
set(CMAKE_CXX_STANDARD 17)
elseif(LLVM_VERSION_MAJOR GREATER 9)
set(CMAKE_CXX_STANDARD 14)
else()
set(CMAKE_CXX_STANDARD 11)
``` |
upgrade to "-std=c++17" nothing change |
@johnnynunez we will have to fix these failing tests. This might take days ... but it looks like some of these are similar so fixing one will fix multiple tests at once. Can you please slow down on opening pull requests? It's hard to follow and I would have time to review them correctly. @thewtex please don't merge things unless I can have a quick approval on these changes; they are way too massive and I need time to check if everything goes well. @johnnynunez your work is great and I thank you for all the effort you are putting into this :) But you will have to be patient. The pull requests you make are way to big given the many failures we are seeing here.
I propose we take this step by step:
At any point in-between these 5 steps we will have to fix tests. |
thanks! for understanding, is the bug from ompl that occurs some time ago also. So thank you FYI: 20.04 will not run in march. actions/runner-images#11101 |
I'll have a look I will start working on it asap over the next days: #239 |
Thanks you are right. I'll remove it. |
@johnnynunez I have also split out the GitHub Actions update: #240 |
This pull request includes updates to the GitHub Actions workflow configuration to support new operating system versions and architectures, as well as updates to the setup steps for various tools.
Workflow Configuration Updates:
.github/workflows/tests.yml
: Updated the matrix to includearch
and added support forubuntu-24.04
andubuntu-24.04-arm
with various Python versions and C++ standards. Also, added support formacos-15
witharm64
architecture.Tool Setup Updates:
.github/workflows/tests.yml
: Updated the CastXML setup steps to support the new OS versions and architectures, including specific setup commands forubuntu-24.04
,ubuntu-22.04
, andmacos-15
for bothx86_64
andarm64
architectures.