Skip to content

Fix _HAS_TR1=0 definition for msvc9 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2017
Merged

Conversation

thewtex
Copy link
Contributor

@thewtex thewtex commented Feb 26, 2017

This can get expanded the wrong way with VS9 leading to a compile error.

This can get expanded the wrong way with VS9 leading to a compile error.
@thewtex thewtex requested a review from iMichka February 26, 2017 15:54
@coveralls
Copy link

coveralls commented Feb 26, 2017

Coverage Status

Coverage remained the same at 92.873% when pulling 1a75c4c on thewtex:vs9 into 1a154bc on gccxml:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.873% when pulling 1a75c4c on thewtex:vs9 into 1a154bc on gccxml:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.873% when pulling 1a75c4c on thewtex:vs9 into 1a154bc on gccxml:develop.

Copy link
Collaborator

@iMichka iMichka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks!

@iMichka iMichka merged commit 451d3cd into CastXML:develop Feb 26, 2017
@iMichka iMichka added the bug label Feb 26, 2017
@iMichka iMichka added this to the 1.8.6 milestone Feb 26, 2017
@iMichka
Copy link
Collaborator

iMichka commented Feb 26, 2017

I'll add this to the 1.8.6 release, it may take a few days because I want to have a look to another bug first. I will also have a look at the Microsoft Visual C++ Compiler for Python 2.7. Thanks.

@thewtex
Copy link
Contributor Author

thewtex commented Feb 26, 2017

Thanks @iMichka !

@thewtex thewtex deleted the vs9 branch February 26, 2017 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants