Super ultrawide support #518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change minimum width since additional selections cause a scroll bar.
Add additional narrower selections for width percentage for super ultra-wide monitors (32:9)
|
Ah this probably makes sense. I think it should only be jumps of 2 percent though for the new numbers, just like the old ones. That'll be precise enough. I'll have a look at the styling issue, it's probably the way to go for that weird interaction. |
|
I went to 1 steps, because being double wide, it makes the same amount of "pixels" per step. :) |
|
Yeah but still, it's just too many I feel. |
|
Should I work up a more complicated patch with a setting that let's you pick your monitor type and presents a halved valve list and is back to not needing to scroll? |
|
Nah no need to overcomplicate it I think, just do steps of 2 for everyone and it'll be fiiine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some additional narrower width percentage selections to get a narrower compact view on super ultra-wide monitors (32:9) that is comparable to the widths that the existing list makes on standard 16:9 monitors.
Note: I'm not positive increasing the minimal_width in the style is the best solution, but without the change the scroll bar makes all the added choices get an ellipsis and not show the whole number.