Skip to content

Fix ocsp spelling error #13364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Fix ocsp spelling error #13364

merged 2 commits into from
May 6, 2025

Conversation

ericeberry
Copy link
Contributor

Description:

  • Fix OCSP spelling errors

Rationale:

  • OCSP was erroneously spelled OSCP in several places.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 18, 2025
Copy link

openshift-ci bot commented Apr 18, 2025

Hi @ericeberry. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Mab879
Copy link
Member

Mab879 commented Apr 19, 2025

I would prefer if we didn't edit the reference files. If they need to be fixed a ticket with DISA should be filed.

@dodys dodys added this to the 0.1.77 milestone Apr 22, 2025
@dodys dodys self-assigned this Apr 22, 2025
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys
Copy link
Contributor

dodys commented Apr 23, 2025

@ericeberry could you take a look at the failing tests on Ubuntu?

@dodys
Copy link
Contributor

dodys commented Apr 30, 2025

@ericeberry the Ubuntu test is still failing, is this a result of your changes?

Copy link

codeclimate bot commented May 6, 2025

Code Climate has analyzed commit 2c6c936 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 merged commit 930d235 into ComplianceAsCode:master May 6, 2025
98 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants