-
Notifications
You must be signed in to change notification settings - Fork 11
Feat/add UI #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add UI #391
Conversation
63139fd
to
778881c
Compare
53f0ce3
to
4e797d5
Compare
578038d
to
61e3fcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!!
crate/server/src/tests/cover_crypt_tests/integration_tests_tags.rs
Outdated
Show resolved
Hide resolved
crate/server/src/tests/cover_crypt_tests/integration_tests_tags.rs
Outdated
Show resolved
Hide resolved
crate/server/src/tests/cover_crypt_tests/integration_tests_tags.rs
Outdated
Show resolved
Hide resolved
crate/server/src/tests/cover_crypt_tests/integration_tests_tags.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 36 out of 37 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- cli: Language not supported
Comments suppressed due to low confidence (2)
crate/crypto/src/crypto/symmetric/symmetric_ciphers.rs:337
- [nitpick] The error message for short plaintext refers generally to block encryption, but the condition applies only to XTS mode. Consider clarifying the error message to indicate that this requirement is specific to XTS mode encryption.
if plaintext.len() < 16 && matches!(sym_cipher, SymCipher::Aes128Xts | SymCipher::Aes256Xts)
crate/crypto/src/crypto/wrap/wrap_key.rs:231
- [nitpick] The error message for using RSA in the AES wrapping key context could be clearer. Consider rephrasing it to specify that RSA is unsupported for AES wrapping operations.
if cryptographic_algorithm == CryptographicAlgorithm::RSA {
attributes.set_tags(tags).unwrap_or_default(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of unwrap_or_default() here may silently ignore errors when setting tags. Consider handling the error explicitly to ensure that tag assignment issues are not overlooked.
attributes.set_tags(tags).unwrap_or_default(); | |
if let Err(e) = attributes.set_tags(tags) { | |
eprintln!("Failed to set tags: {:?}", e); | |
} |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
0b55e39
to
fe7d8b9
Compare
* feat: add packaging for DEB, RPM and docker * fix: PR review
No description provided.