Skip to content

Feat/add UI #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 10, 2025
Merged

Feat/add UI #391

merged 16 commits into from
Apr 10, 2025

Conversation

ccorsin
Copy link
Contributor

@ccorsin ccorsin commented Mar 26, 2025

No description provided.

@ccorsin ccorsin force-pushed the feat/add_ui branch 7 times, most recently from 63139fd to 778881c Compare April 3, 2025 09:38
@ccorsin ccorsin force-pushed the feat/add_ui branch 2 times, most recently from 53f0ce3 to 4e797d5 Compare April 4, 2025 11:48
@ccorsin ccorsin changed the title Draft: Feat/add UI Feat/add UI Apr 4, 2025
@ccorsin ccorsin force-pushed the feat/add_ui branch 2 times, most recently from 578038d to 61e3fcd Compare April 7, 2025 15:02
Copy link
Contributor

@Manuthor Manuthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!!

@Manuthor Manuthor requested a review from Copilot April 8, 2025 09:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 36 out of 37 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • cli: Language not supported
Comments suppressed due to low confidence (2)

crate/crypto/src/crypto/symmetric/symmetric_ciphers.rs:337

  • [nitpick] The error message for short plaintext refers generally to block encryption, but the condition applies only to XTS mode. Consider clarifying the error message to indicate that this requirement is specific to XTS mode encryption.
if plaintext.len() < 16 && matches!(sym_cipher, SymCipher::Aes128Xts | SymCipher::Aes256Xts)

crate/crypto/src/crypto/wrap/wrap_key.rs:231

  • [nitpick] The error message for using RSA in the AES wrapping key context could be clearer. Consider rephrasing it to specify that RSA is unsupported for AES wrapping operations.
if cryptographic_algorithm == CryptographicAlgorithm::RSA {

Comment on lines +46 to +47
attributes.set_tags(tags).unwrap_or_default();

Copy link
Preview

Copilot AI Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of unwrap_or_default() here may silently ignore errors when setting tags. Consider handling the error explicitly to ensure that tag assignment issues are not overlooked.

Suggested change
attributes.set_tags(tags).unwrap_or_default();
if let Err(e) = attributes.set_tags(tags) {
eprintln!("Failed to set tags: {:?}", e);
}

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

@ccorsin ccorsin force-pushed the feat/add_ui branch 2 times, most recently from 0b55e39 to fe7d8b9 Compare April 8, 2025 16:13
* feat: add packaging for DEB, RPM and docker

* fix: PR review
@Manuthor Manuthor merged commit e1bf368 into develop Apr 10, 2025
21 checks passed
@Manuthor Manuthor deleted the feat/add_ui branch April 10, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants