Add API Token Auth Support #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the support to use PVE API Tokens.
How it function
===========
the class now parse the password parameter ($this->password). if there a ":" in password they will be use token authentification.
if not the class is use username + password authentification
So the class is compatible backwards
How to use
========
Login with username & password:
$pve2 = new PVE2_API("hostname", "username", "realm", "password");
Login with API Token:
$pve2 = new PVE2_API("hostname", "username", "realm", "TokenID:TokenValue");
Example:
$pve2 = new PVE2_API("hostname", "root", "pam", "TestToken:7381a050-0185-43d1-a651-0c30a2bba5cc");
|
I think that using the presence of a colon in the password is too unpredictable, especially in current times. Perhaps if the password field is null when PVE2_API is initiated, a new field in the request can be checked?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the support for auth with API Token
How it works
the class now parse the password parameter ($this->password). if there a ":" in password they will be use token authentification.
if not the class is use username + password authentification
So the class is compatible backwards
How to use
Login with username & password:
$pve2 = new PVE2_API("hostname", "username", "realm", "password");
Login with API Token:
$pve2 = new PVE2_API("hostname", "username", "realm", "TokenID:TokenValue");
Example:
$pve2 = new PVE2_API("hostname", "root", "pam", "TestToken:7381a050-0185-43d1-a651-0c30a2bba5cc");