-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement metanetx service #1
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=========================================
Coverage ? 84.18%
=========================================
Files ? 8
Lines ? 253
Branches ? 0
=========================================
Hits ? 213
Misses ? 40
Partials ? 0
Continue to review full report at Codecov.
|
refactor: include data in repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good prototype of the service. Next steps for me are:
- Persist information in a database (SQLAlchemy + postgres).
- Build a more powerful search (Elastic or Lucene or at least Whoosh).
- Cache responses using Redis.
stream=True, | ||
) | ||
response.raise_for_status() | ||
for row in csv.DictReader(response.iter_lines(decode_unicode=True), delimiter="\t"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is of course perfectly fine but I would use pandas for anything tabular unless there is a really good reason not to include it as a dependency.
No description provided.