Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Paste] Paste function #19

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

hanstig
Copy link

@hanstig hanstig commented Mar 4, 2024

Reverted the from a newer jabref version to remove extra commits in PR #18

Added paste functionality.
The paste function now automatically copies any string constants in the clipboard and adds them
to the current library's database of string constants.

It performs checks to see if the copied string constants are correctly formatted and not duplicates of
already existing string constants.

As new dialog messages have been added, these have also been added to the English localization file, but localization for other languages are missing

fixes issue #9

hanstig added 2 commits March 3, 2024 05:07
Add functionality to import string constants in the paste function

Should add functionality to handle colliding string constants.
Should also check that the constants are valid using the
ConstantsItemModel class.
Check that a pasted string constant is valid using the
ConstantsItemModel class.

Add diagnostic messages notifying users when adding a string constant
fails while pasting.
@hanstig hanstig added the enhancement New feature or request label Mar 4, 2024
@hanstig hanstig changed the title Paste function [Paste] Paste function Mar 4, 2024
Copy link

@andersblomqvist andersblomqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@andersblomqvist andersblomqvist merged commit e49562f into fix-for-issue-10872 Mar 4, 2024
@andersblomqvist andersblomqvist deleted the paste-function-revert branch March 4, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants