OMP - Internal User - All appropriate authority Issued charge changes #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/EA.Weee.Domain.Tests.Unit/Producer/ProducerSubmissionTests.cs
Outdated
Show resolved
Hide resolved
src/EA.Weee.Domain.Tests.Unit/Producer/ProducerSubmissionTests.cs
Outdated
Show resolved
Hide resolved
src/EA.Weee.Domain.Tests.Unit/Producer/ProducerSubmissionTests.cs
Outdated
Show resolved
Hide resolved
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
src/EA.Weee.RequestHandlers/Charges/FetchIssuedChargesCsv/FetchIssuedChargesCsvHandler.cs
Outdated
Show resolved
Hide resolved
src/EA.Weee.RequestHandlers/Charges/FetchIssuedChargesCsv/FetchIssuedChargesCsvHandler.cs
Outdated
Show resolved
Hide resolved
…k into a derived property My review comment was wrong about this one
…ue from the domain object since they both use the same database field, at the moment, we'll make the decision of which to use in the request handler For now, return empty string for OMP column (doesn't break a test as it's too basic currently)
… for OMP vs the other SellingTechniqueTypes
… CSV column headers
…s in the CSV correct column depending on the SellingTechniqueType
|
I've ended up implementing some of this, so while I'm happy, and Sreedhar can't approve his own PR, it needs a comment from him to confirm he's happy (or that he's not!) |
…chniqueType as well
…display value for SellingTechniqueType from domain to CSV handler
creating a ProducerSubmission was being done wrong; it failed sometimes because some of the dummies actually needed to have matching values, which meant they couldn't be dummies BUT we're not trying to test the ProducerSubmission here, so a fake of the whole object achieves what we need, with just the specific values returned
It wasn't correct to revert this; the properties can't be faked in this way (turned out due to an oversight I hadn't actually run the test any of the times I thought I had) This reverts commit f1eb180.
…s nullable Otherwise it doesn't match if parameter ends up being null
Use fakes instead of dummies, as specific parts need to match each other / be set Set the parts of the fake the CSV creator can reasonably expect
|
Looks good. |
|
Sreedhar made some suggestions so I made some further change; think it's all sorted now. |
CivicaJonathanStratford
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.