Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #152

Merged
merged 6 commits into from
Feb 22, 2023
Merged

Fix warnings #152

merged 6 commits into from
Feb 22, 2023

Conversation

ecomodeller
Copy link
Member

....makes it easier to take warnings seriously.

@jsmariegaard
Copy link
Member

@ecomodeller can we merge this before now?

@jsmariegaard jsmariegaard self-requested a review February 22, 2023 10:56
@jsmariegaard jsmariegaard marked this pull request as ready for review February 22, 2023 10:56
Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only 2 warnings left

@jsmariegaard
Copy link
Member

@ecomodeller can we merge this before now?

Looks good. I will merge :-)

@jsmariegaard jsmariegaard merged commit a4b30d0 into main Feb 22, 2023
@jsmariegaard jsmariegaard deleted the fix_warnings branch February 22, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants