Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mood Style #160

Merged
merged 12 commits into from
Jan 27, 2023
Merged

Mood Style #160

merged 12 commits into from
Jan 27, 2023

Conversation

daniel-caichac-DHI
Copy link
Collaborator

@daniel-caichac-DHI daniel-caichac-DHI commented Jan 17, 2023

Hi @jsmariegaard
I ended up doing a new branch with mood style as per your suggestion. Much cleaner.

I think we can close the old branch: #150

by default now you get this
image

and when style=MOOD
image

@daniel-caichac-DHI daniel-caichac-DHI marked this pull request as ready for review January 17, 2023 13:02
@ecomodeller ecomodeller marked this pull request as draft January 24, 2023 11:51
@ecomodeller ecomodeller marked this pull request as ready for review January 24, 2023 12:50
Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @daniel-caichac-DHI . I like your implementation. But I think you miss the alignment of the numbers in the skill table, you implemented in the other PR:

image

Could you please add that again?

@daniel-caichac-DHI
Copy link
Collaborator Author

Sure, no idea why they are gone, they should have been there.
I will add them

formatted as requested
@jsmariegaard
Copy link
Member

I don't why you changed the font size, but the monospace font now makes the alignment work. You still miss the equal signs, though.

image

@daniel-caichac-DHI
Copy link
Collaborator Author

daniel-caichac-DHI commented Jan 27, 2023

Because I looked at the formatting done by Hendrik and he had those 2 lines (font size and left justification), I just copied the lines from the old PR

I can see the space here
https://github.com/DHI/fmskill/blob/2a5b73dc6a794c4b44ea74fb7281cce38d991c40/fmskill/plot.py#L579

I also just pulled the branch after your last update and it works
image

Merge then :) ???

@jsmariegaard jsmariegaard merged commit ed50aa9 into main Jan 27, 2023
@jsmariegaard jsmariegaard deleted the mood_style branch January 27, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants