Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve by argument in skill() #331

Closed
wants to merge 4 commits into from
Closed

Improve by argument in skill() #331

wants to merge 4 commits into from

Conversation

jsmariegaard
Copy link
Member

@jsmariegaard jsmariegaard commented Dec 14, 2023

Expand by argument in skill() with two new features:

  • "dt:" e.g. "dt:month" (which is different from "freq:month").
  • "attrs:" e.g. "attrs:gtype" or "attrs:DA" (to distinguish between assimilation and validation stations)

Examples:

image

image

@ecomodeller
Copy link
Member

Quarters is not the most natural aggregation period in natural systems. More relevant for business data.

How about aggregating by season?

Season Abbreviation Months
Winter DJF December, January, February
Spring MAM March, April, May
Summer JJA June, July, August
Autumn SON September, October, November

@jsmariegaard
Copy link
Member Author

Quarters is not the most natural aggregation period in natural systems. More relevant for business data.

How about aggregating by season?

Season Abbreviation Months
Winter DJF December, January, February
Spring MAM March, April, May
Summer JJA June, July, August
Autumn SON September, October, November

Agree. It was not the best example. The idea with this feature is to provide access to the Pandas dt accessor on the index and be able to group by that. In Urban context I guess 'day_of_week' could be relevant, in natural environments it could be 'month'.

This was referenced Dec 19, 2023
@jsmariegaard
Copy link
Member Author

superseded by #351 and #352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants