-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add toy data #493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
What is an acceptable data file size to include in the package? 1MB per case? Should we maybe remove some stations in above examples? Could we reduce to float16 or use other tricks to save some file size? |
I think we can remove some stations and change to float32. |
…elskill into Feature-489-add-toy-data
…-489-add-toy-data
Ways to make datasets smaller on disk:
Further ideas to reduce disk size (not tried):
|
…-489-add-toy-data
ecomodeller
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both datasets are now around 1MB, both contains aux data and attrs, that could be used for examples and testing in the future (not yet used). The data module has been added to the api docs.
And a later point it would be great to add more datasets: nortseawaves, ...
It would also be great to add the new notebook to the examples in docs.