Validation and metrics #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewuerger
force-pushed
the
validation-and-metrics
branch
3 times, most recently
from
c417c81 to
abfab95
Compare
|
This is still not ready to merge. I just hope to get a review for improving the code. |
MS34449
suggested changes
Apr 14, 2023
vik378
reviewed
Apr 16, 2023
ewuerger
force-pushed
the
validation-and-metrics
branch
from
e6468c0 to
7dc4657
Compare
ewuerger
force-pushed
the
validation-and-metrics
branch
2 times, most recently
from
214912b to
5de2daf
Compare
MS34449
suggested changes
Apr 19, 2023
There was a problem hiding this comment.
Reg. verb-noun: rationale="Using the verb-noun pattern for naming behaviors promotes clarity, "
"consistency, and effective communication across the system. Adhering "
"to this convention simplifies understanding and management for all "
"stakeholders. Please revise any non-compliant names to align with "
"this proven practice." is actually a hint that even with optimal temperature=0.8 param setting ChatGPT still produces rather flat generalisms... I recommend this: "Behaviour name shall follow pattern." and rationale="Behaviour means acting on an object."
MS34449
suggested changes
Apr 19, 2023
MS34449
reviewed
Apr 19, 2023
Add rules implemented in [bf676a6], with reworded descriptions to match the suggestive style. [bf676a6]: MS34449@bf676a6 Co-authored-by: Marek Sechny <82209355+MS34449@users.noreply.github.com>
Wuestengecko
force-pushed
the
validation-and-metrics
branch
from
f193726 to
1a7ca1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version. Convenient access of validation rules should be implemented next. Empty tests are already added. The validation rules infrastructure was implemented. Test coverage is at 95%.