Skip to content

[WIP] Add support for processor overrides #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Anilm3
Copy link
Contributor

@Anilm3 Anilm3 commented Apr 15, 2025

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@pr-commenter
Copy link

pr-commenter bot commented Apr 15, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-04-17 12:20:35

Comparing candidate commit 6fcd044 in PR branch anilm3/processor-overrides with baseline commit b2a1ef5 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+11.930µs; +16.182µs] or [+6.409%; +8.694%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.38%. Comparing base (b2a1ef5) to head (6fcd044).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3213      +/-   ##
============================================
- Coverage     79.30%   76.38%   -2.93%     
  Complexity     2943     2943              
============================================
  Files           117      144      +27     
  Lines         11603    16046    +4443     
  Branches          0     1107    +1107     
============================================
+ Hits           9202    12257    +3055     
- Misses         2401     3214     +813     
- Partials          0      575     +575     
Flag Coverage Δ
appsec-extension 68.80% <ø> (?)
tracer-php 79.28% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a1ef5...6fcd044. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants