-
Notifications
You must be signed in to change notification settings - Fork 1.2k
DOCS-10600: Tracing API Gateway #28916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview links (active after the
|
Added DOCS-10711 to track docs review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small comment but nothing blocking approval
{{< callout url="#" btn_hidden="true" header="Tracing for Amazon API Gateway is in Preview" >}} | ||
This feature is in Preview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we need both the header and the message? Might be duplicative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor tweaks. Otherwise, looks great!
API Gateway must pass the following headers in the request for the tracer to create the inferred span: | ||
| header | value | | ||
| ------ | ----- | | ||
| `x-dd-proxy` | `'aws-apigateway'` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm removing the quotes to stay consistent with the other things, but I'm not sure if this is required (this is the only guy that doesn't follow the context.*
pattern, so I don't know if the quotes were intentional/appropriate).
| `x-dd-proxy` | `'aws-apigateway'` | | |
| `x-dd-proxy` | `aws-apigateway` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup—the quotes should be kept on this one
Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated pages look good to me!
I'm seeing the API Gateway logo on the Tracing Proxies page and it's linking to the new docs as expected
https://docs-staging.datadoghq.com/cswatt/aws-api-gateway/tracing/trace_collection/proxy_setup/
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
* initial commit * adding further reading * removing button * splitting column * edits * update * add link * Apply suggestions from code review Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com> --------- Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
* initial commit * adding further reading * removing button * splitting column * edits * update * add link * Apply suggestions from code review Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com> --------- Co-authored-by: domalessi <111786334+domalessi@users.noreply.github.com>
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes