[web-6385] custom rum action for cdocs #28990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Deutsch <brian.deutsch@datadoghq.com>
jhgilbert
reviewed
Apr 25, 2025
| document.addEventListener('DOMContentLoaded', () => { | ||
| if (window.clientFiltersManager) { | ||
| handleCdocsCustomRumAction(); | ||
| clientFiltersManager.registerHook('afterRerender', handleCdocsCustomRumAction); |
There was a problem hiding this comment.
Suggested change
| clientFiltersManager.registerHook('afterRerender', handleCdocsCustomRumAction); | |
| clientFiltersManager.registerHook('afterReveal', handleCdocsCustomRumAction); |
You would just need this if you don't want to miss the first filter adjustment (since a rerender won't happen until after the first one)
There was a problem hiding this comment.
thanks jen! i tested this and having the initial call on line 100 handleCdocsCustomRumAction() made sure the first filter adjustment was captured.
davidejones
approved these changes
Apr 29, 2025
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
adds a custom rum action for cdocs
thought it would be interesting see users interacting once usage ramps up
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes
https://docs-staging.datadoghq.com/brian.deutsch/web-6385-rum-action-cdocs/real_user_monitoring/guide/proxy-mobile-rum-data
click the filter buttons. there should be no JS errors on this page (or other pages).
custom rum action appears in DD i.e. : https://dd-corpsite.datadoghq.com/rum/sessions?query=%40type%3Aaction%20%40application.id%3A3493b4e7-ab12-4852-8836-ba96af7bc745%20%40action.type%3Acustom&agg_m=count&agg_m_source=base&agg_t=count&cols=&event=AwAAAZZuorS0AwA1ygAAABhBWlp1b3J1bEFBQk1iSW10YTBnR0Z3QUIAAAAkMDE5NjZlYTItYzQ5ZC00YjQxLWFlOGQtZWFmNTU3NmRiNTM5AAAACw&fromUser=false&viz=stream&from_ts=1745612586693&to_ts=1745612886693&live=true