Skip to content

[RUM-9722] Add remote configuration instructions to all auto injection setup #29005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Apr 28, 2025

What does this PR do? What is the motivation?

Simplify the auto-injection + remote configuration doc:

  • Remove the "Remotely configure your RUM applications in Datadog" section from the main page.
  • Integrate the remote configuration instructions into the setup pages for each web server adding screenshots
  • Move "Manual installation" out of "Set up your RUM application" to focus that section on the Remote Configuration (RC) flow. Place "Manual installation" later in the page under a new section titled "(Alternative) Manual installation"

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@github-actions github-actions bot added the Images Images are added/removed with this PR label Apr 28, 2025
@amortemousque amortemousque force-pushed the aymeric/auto-injection-remote-configuration branch from f760f67 to 1b1b327 Compare April 29, 2025 09:06
@amortemousque amortemousque changed the title Add remote configuration instructions to all auto injection setup [RUM-9722] Add remote configuration instructions to all auto injection setup Apr 29, 2025
@rtrieu rtrieu self-requested a review April 29, 2025 14:03
Copy link

@allspain allspain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor non-blocking comment

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! I left a few suggestions for your review.

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated some of my suggestions.

@amortemousque amortemousque marked this pull request as ready for review April 30, 2025 09:16
@amortemousque amortemousque requested review from a team as code owners April 30, 2025 09:16
@estherk15 estherk15 requested a review from rtrieu April 30, 2025 17:25
@rtrieu rtrieu added the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 30, 2025
@rtrieu
Copy link
Contributor

rtrieu commented May 2, 2025

Waiting for our discussion on Monday before further review. In the meantime, you are probably aware, but I see the branch has some conflicts @pablomartinezbernardo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR WORK IN PROGRESS No review needed, it's a wip ;)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants