Skip to content

[RUM] Auto-instrumentation updates v3 #29009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Apr 28, 2025

What does this PR do? What is the motivation?

Per PM discussion, this makes the following changes:

  • Add preview banner to landing page
  • Adds a diagram explaining how auto-instrumentation works
  • Puts auto-instrumentation vs client-side instrumentation comparisons in a table

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@rtrieu rtrieu added the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 28, 2025
@rtrieu rtrieu requested review from a team as code owners April 28, 2025 16:15
@rtrieu rtrieu removed the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 29, 2025
@aliciascott aliciascott self-assigned this Apr 29, 2025
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rtrieu left a little bit of feedback and I'm also confused on the layout as none of the RUM -> Setup -> Server pages are in the left Nav, not sure if this was intentional ?

image

Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
@rtrieu rtrieu requested a review from aliciascott April 29, 2025 19:51
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates looks good! Also thanks for confirming the server pages aren't yet intended to be on the Nav :) I'll let you merge when ready!

@rtrieu
Copy link
Contributor Author

rtrieu commented Apr 30, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 30, 2025

View all feedbacks in Devflow UI.

2025-04-30 20:56:25 UTC ℹ️ Start processing command /merge


2025-04-30 20:56:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-04-30 21:17:20 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 7cb7a3c into master Apr 30, 2025
20 of 21 checks passed
@dd-mergequeue dd-mergequeue bot deleted the rtrieu/rum-auto-instrumention-v3 branch April 30, 2025 21:17
aldrickdev pushed a commit that referenced this pull request May 7, 2025
* Add table, rearrange uninstall

* remove duplicate info

* Apply suggestions from code review

Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>

* Update content/en/real_user_monitoring/browser/setup/_index.md

---------

Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
estherk15 pushed a commit that referenced this pull request May 8, 2025
* Add table, rearrange uninstall

* remove duplicate info

* Apply suggestions from code review

Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>

* Update content/en/real_user_monitoring/browser/setup/_index.md

---------

Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants