-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[RUM] Auto-instrumentation updates v3 #29009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rtrieu left a little bit of feedback and I'm also confused on the layout as none of the RUM -> Setup -> Server pages are in the left Nav, not sure if this was intentional ?

content/en/real_user_monitoring/browser/setup/server/windows_iis.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates looks good! Also thanks for confirming the server pages aren't yet intended to be on the Nav :) I'll let you merge when ready!
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
* Add table, rearrange uninstall * remove duplicate info * Apply suggestions from code review Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com> * Update content/en/real_user_monitoring/browser/setup/_index.md --------- Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
* Add table, rearrange uninstall * remove duplicate info * Apply suggestions from code review Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com> * Update content/en/real_user_monitoring/browser/setup/_index.md --------- Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
What does this PR do? What is the motivation?
Per PM discussion, this makes the following changes:
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes