Skip to content

Add Baggage as Default Propagator #29060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 30, 2025
Merged

Conversation

rachelyangdog
Copy link
Contributor

@rachelyangdog rachelyangdog commented Apr 30, 2025

What does this PR do? What is the motivation?

  • adds baggage propagator to docs and updates language portions

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@rachelyangdog rachelyangdog requested a review from a team as a code owner April 30, 2025 15:20
Copy link
Contributor

@duncanhewett duncanhewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

We also describe the context propagation related config on the individual language configuration pages for example, Go so it would be good to make sure the correct defaults are documented on those pages as well.

@bm1549
Copy link
Contributor

bm1549 commented Apr 30, 2025

Aside from this page, there are a handful of other pages that should be updated as well

@estherk15 estherk15 self-assigned this Apr 30, 2025
@rachelyangdog rachelyangdog requested a review from a team as a code owner April 30, 2025 17:46
@rachelyangdog
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 30, 2025

View all feedbacks in Devflow UI.

2025-04-30 20:41:34 UTC ℹ️ Start processing command /merge


2025-04-30 20:41:40 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-04-30 20:59:31 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f7e6567 into master Apr 30, 2025
15 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the rachel.yang/baggage-prop branch April 30, 2025 20:59
aldrickdev pushed a commit that referenced this pull request May 7, 2025
* Update DD_TRACE_PROPAGATION_STYLE default values

* Update content/en/tracing/trace_collection/trace_context_propagation/_index.md

Co-authored-by: Brian Marks <bm1549@users.noreply.github.com>

* language section

* Add baggage default propagator

* updating all files

---------

Co-authored-by: Brian Marks <bm1549@users.noreply.github.com>
estherk15 pushed a commit that referenced this pull request May 8, 2025
* Update DD_TRACE_PROPAGATION_STYLE default values

* Update content/en/tracing/trace_collection/trace_context_propagation/_index.md

Co-authored-by: Brian Marks <bm1549@users.noreply.github.com>

* language section

* Add baggage default propagator

* updating all files

---------

Co-authored-by: Brian Marks <bm1549@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants