Skip to content

Moved Code Origins content under /tracing parent instead of /guide #29065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 1, 2025

Conversation

sstonehill12
Copy link
Contributor

@sstonehill12 sstonehill12 commented Apr 30, 2025

What does this PR do? What is the motivation?

The Code Origins page had originally been stored under the /guides folder, but really belongs under /tracing.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@sstonehill12 sstonehill12 added the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 30, 2025
@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR Guide Content impacting a guide labels Apr 30, 2025
Copy link
Contributor

@sstonehill12 sstonehill12 removed the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 30, 2025
@sstonehill12 sstonehill12 marked this pull request as ready for review April 30, 2025 17:55
@sstonehill12 sstonehill12 requested a review from a team as a code owner April 30, 2025 17:55
@estherk15
Copy link
Contributor

Looks good, I added the alias for redirects since the URL changed. Let me know if you have any questions!

@sstonehill12
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 1, 2025

View all feedbacks in Devflow UI.

2025-05-01 13:49:26 UTC ℹ️ Start processing command /merge


2025-05-01 13:49:30 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-05-01 13:53:13 UTCMergeQueue: The build pipeline failed for this merge request

Build pipeline has failing jobs for b9326d3:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@sstonehill12
Copy link
Contributor Author

Hi @estherk15! Do you know why the merge failed? Do I need to fix something before this can be merged?

@estherk15
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 1, 2025

View all feedbacks in Devflow UI.

2025-05-01 15:51:41 UTC ℹ️ Start processing command /merge


2025-05-01 15:51:48 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-01 19:23:08 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-05-01 19:38:59 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit e5f3e21 into master May 1, 2025
14 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the sarah.stonehill/code-origins-folder-change branch May 1, 2025 19:38
aldrickdev pushed a commit that referenced this pull request May 7, 2025
…29065)

Co-authored-by: estherk15 <esther.kim@datadoghq.com>
estherk15 added a commit that referenced this pull request May 8, 2025
…29065)

Co-authored-by: estherk15 <esther.kim@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend Guide Content impacting a guide Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants