Skip to content

Cost Recommendations ga updates #29071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 1, 2025
Merged

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Apr 30, 2025

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

colbyh19 and others added 3 commits April 28, 2025 10:45
Updating our cost recommendations docs for our GA and all the new features we've released recently
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
@rtrieu rtrieu requested a review from a team as a code owner April 30, 2025 17:50
@rtrieu rtrieu self-assigned this Apr 30, 2025
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor Author

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback for your review, mainly to comply with our style guide (including removing temporal words because we document features as they are, not how they used to or will be) and to remove the preview banner entirely. Let me know if you have any questions, and when this is ready for a re-review!

colbyh19 and others added 7 commits April 30, 2025 14:16
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
@rtrieu rtrieu removed their assignment Apr 30, 2025
@rtrieu
Copy link
Contributor Author

rtrieu commented May 1, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 1, 2025

View all feedbacks in Devflow UI.

2025-05-01 18:21:36 UTC ℹ️ Start processing command /merge


2025-05-01 18:21:41 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-05-01 18:40:38 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 420295d into master May 1, 2025
18 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the colbyh/cost-recs-ga-updates branch May 1, 2025 18:40
aldrickdev pushed a commit that referenced this pull request May 7, 2025
Co-authored-by: colbyh19 <colby.hanley@datadoghq.com>
estherk15 pushed a commit that referenced this pull request May 8, 2025
Co-authored-by: colbyh19 <colby.hanley@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants