Skip to content

[CCC-695] Add details for CCM Read/Write permissions #29076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

kaankoseler
Copy link
Contributor

What does this PR do? What is the motivation?

We have recently tightened up our enforcement of the Cloud Cost Management Read and Write permissions. As a result, we want to provide some more granular detail to users regarding the behavior of the permissions.

Happy to take any feedback for how to structure this!

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@kaankoseler kaankoseler requested a review from a team as a code owner April 30, 2025 19:21
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@estherk15 estherk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left one suggestion!

Co-authored-by: Esther Kim <esther.kim@datadoghq.com>
@kaankoseler
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 30, 2025

View all feedbacks in Devflow UI.

2025-04-30 20:46:59 UTC ℹ️ Start processing command /merge


2025-04-30 20:47:06 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-04-30 21:12:12 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-04-30 21:31:00 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit cf94e9f into master Apr 30, 2025
16 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the kaan.koseler/add_docs_for_ccm_perms branch April 30, 2025 21:30
aldrickdev pushed a commit that referenced this pull request May 7, 2025
* feat: modify basic descriptions

* Apply suggestions from code review

Co-authored-by: Esther Kim <esther.kim@datadoghq.com>

---------

Co-authored-by: Esther Kim <esther.kim@datadoghq.com>
estherk15 added a commit that referenced this pull request May 8, 2025
* feat: modify basic descriptions

* Apply suggestions from code review

Co-authored-by: Esther Kim <esther.kim@datadoghq.com>

---------

Co-authored-by: Esther Kim <esther.kim@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants