[SVLS-3965] Add doc for instrumenting Step Functions using AWS SAM #29156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lym953
changed the title
Preview links (active after the
|
maycmlee
reviewed
May 5, 2025
| @@ -185,6 +185,28 @@ For sample stacks and additional code examples, see [CDK Examples for Instrument | |||
| [3]: https://github.com/DataDog/datadog-cdk-constructs | |||
| [4]: /serverless/guide/step_functions_cdk | |||
| {{% /tab %}} | |||
| {{% tab "AWS SAM" %}} | |||
| 1. Ensure you have deployed the [Datadog Lambda Forwarder][1], and that you are using v3.130.0+. You might need to [update your Forwarder][1]. | |||
There was a problem hiding this comment.
When would the user need to update the Forwarder?
There was a problem hiding this comment.
This line is copied from other tabs. I think it means user need to update the forwarder if the version is too old.
There was a problem hiding this comment.
actually, it does seem a bit redundant to say. I'll remove that line entirely.
| @@ -185,6 +185,28 @@ For sample stacks and additional code examples, see [CDK Examples for Instrument | |||
| [3]: https://github.com/DataDog/datadog-cdk-constructs | |||
| [4]: /serverless/guide/step_functions_cdk | |||
| {{% /tab %}} | |||
| {{% tab "AWS SAM" %}} | |||
| 1. Ensure you have deployed the [Datadog Lambda Forwarder][1], and that you are using v3.130.0+. You might need to [update your Forwarder][1]. | |||
There was a problem hiding this comment.
Suggested change
| 1. Ensure you have deployed the [Datadog Lambda Forwarder][1], and that you are using v3.130.0+. You might need to [update your Forwarder][1]. | |
| 1. Ensure you have deployed the [Datadog Lambda Forwarder][1], and that you are using v3.130.0 or later. You might need to [update your Forwarder][1]. |
There was a problem hiding this comment.
@cswatt Would you be able help update this instruction for all of the tabs?
astuyve
approved these changes
May 5, 2025
maycmlee
approved these changes
May 5, 2025
cswatt
approved these changes
May 5, 2025
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
aldrickdev
pushed a commit
that referenced
this pull request
May 7, 2025
…29156) Co-authored-by: cswatt <cecilia.watt@datadoghq.com>
estherk15
pushed a commit
that referenced
this pull request
May 8, 2025
…29156) Co-authored-by: cswatt <cecilia.watt@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Add doc for instrumenting Step Functions using AWS SAM.
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes