-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[CECO-2145] Use datadog.kubelet.useApiServer
for GKE Autopilot
#29199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tbavelier
wants to merge
2
commits into
master
Choose a base branch
from
tbavelier/update-autopilot-to-apiserver-query
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -127,7 +127,7 @@ | |||||
fieldRef: | ||||||
fieldPath: spec.nodeName | ||||||
hostCAPath: /etc/kubernetes/certs/kubeletserver.crt | ||||||
|
||||||
providers: | ||||||
aks: | ||||||
enabled: true | ||||||
|
@@ -146,7 +146,7 @@ | |||||
In some clusters, DNS resolution for `spec.nodeName` inside Pods does not work in AKS. This affects: | ||||||
- Windows nodes | ||||||
- Linux nodes, when the cluster is set up in a virtual network using custom DNS | ||||||
|
||||||
In this case, use the AKS configuration provided below to set `tlsVerify: false` and remove any settings for the Kubelet host path (which defaults to `status.hostIP`). **Do not set the Kubelet host path and `tlsVerify: false` in the same configuration**. | ||||||
|
||||||
{{< tabs >}} | ||||||
|
@@ -217,9 +217,11 @@ | |||||
|
||||||
GKE Autopilot requires some configuration, shown below. | ||||||
|
||||||
Datadog recommends that you specify resource limits for the Agent container. Autopilot sets a relatively low default limit (50m CPU, 100Mi memory) that may lead the Agent container to quickly OOMKill depending on your environment. If applicable, also specify resource limits for the Trace Agent and Process Agent containers. Additionally, you may wish to create a priority class for the Agent to ensure it is scheduled. | ||||||
Datadog recommends that you specify resource limits for the Agent container. Autopilot sets a relatively low default limit (50m CPU, 100Mi memory) that may lead the Agent container to quickly OOMKill depending on your environment. If applicable, also specify resource limits for the Trace Agent, Process Agent and System-Probe containers. Additionally, you may wish to create a priority class for the Agent to ensure it is scheduled. | ||||||
|
||||||
Starting with Agent `7.65.0+` and version `3.113.0+` of the Helm chart, we also recommend using `datadog.kubelet.useApiServer` for the Agent to query the pod list from the API server instead of the [deprecated read-only kubelet port][12]. | ||||||
Check notice on line 222 in content/en/containers/kubernetes/distributions.md
|
||||||
|
||||||
**Note**: Cloud Network Monitoring is supported from version 3.100.0 of the Helm chart and with GKE version 1.32.1-gke.1729000 or later | ||||||
**Note**: Cloud Network Monitoring is supported from version `3.100.0` of the Helm chart and with GKE version `1.32.1-gke.1729000` or later. | ||||||
|
||||||
{{< tabs >}} | ||||||
{{% tab "Helm" %}} | ||||||
|
@@ -237,6 +239,12 @@ | |||||
# Documentation: https://docs.datadoghq.com/getting_started/site/ | ||||||
site: <DATADOG_SITE> | ||||||
|
||||||
# This option uses the API server to retrieve the node-level pod list from the API server. | ||||||
# This is necessary to migrate away from the deprecated read-only kubelet port. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
# Requires Agent 7.65.0+ and Datadog Helm chart version 3.113.0+. | ||||||
kubelet: | ||||||
useApiServer: true | ||||||
|
||||||
agents: | ||||||
containers: | ||||||
agent: | ||||||
|
@@ -598,3 +606,4 @@ | |||||
[9]: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ | ||||||
[10]: https://cloud.google.com/kubernetes-engine/docs/how-to/autopilot-spot-pods | ||||||
[11]: https://cloud.google.com/kubernetes-engine/docs/concepts/autopilot-compute-classes | ||||||
[12]: https://cloud.google.com/kubernetes-engine/docs/how-to/disable-kubelet-readonly-port |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.