Skip to content

[DOCS-10783] Update instructions #29233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Conversation

buraizu
Copy link
Contributor

@buraizu buraizu commented May 7, 2025

What does this PR do? What is the motivation?

  • Update the instructions to reflect changes in AWS
  • Updates for style, clarity, and consistency

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@buraizu buraizu requested a review from a team as a code owner May 7, 2025 23:58
@github-actions github-actions bot added the Guide Content impacting a guide label May 7, 2025
Copy link
Contributor

github-actions bot commented May 8, 2025

Preview links (active after the build_preview check completes)

Modified Files

@buraizu buraizu mentioned this pull request May 8, 2025
1 task
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @buraizu, the PR looks good! i would just suggest some link numbering cleanup. it's currently skipping 3 and 6.

@buraizu
Copy link
Contributor Author

buraizu commented May 8, 2025

Thanks @rtrieu, I've created DOCS-10845 to fix the link numbering, since making any updates now would dismiss your review.

@buraizu
Copy link
Contributor Author

buraizu commented May 8, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 8, 2025

View all feedbacks in Devflow UI.

2025-05-08 17:37:38 UTC ℹ️ Start processing command /merge


2025-05-08 17:37:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 21m (p90).


2025-05-08 17:54:43 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 8e78591 into master May 8, 2025
18 of 21 checks passed
@dd-mergequeue dd-mergequeue bot deleted the docs10783/update-instructions branch May 8, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants